Skip to content

fix(deps): update ckeditor to 45 (unified package) #11083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
st3iny merged 1 commit into from
Oct 9, 2025
Merged

fix(deps): update ckeditor to 45 (unified package) #11083

st3iny merged 1 commit into from
Oct 9, 2025

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented May 6, 2025 •
edited
Loading

Editor seems to work but there are some errors in the console to look at.

[Vue warn]: Error in render: "TypeError: can't access property "length", _vm.recipients is undefined"

found in

---> <RecipientInfo> at src/components/RecipientInfo.vue
       <NcModal>
         <NewMessageModal> at src/components/NewMessageModal.vue
           <NcContent>
             <Home> at src/views/Home.vue
               <App> at src/App.vue
                 <Root> vue.runtime.esm.js:4625
    VueJS 88
    render Home.vue:18
    VueJS 15
    set pinia.mjs:926
    startComposerSessionMutation actions.js:1849
    wrappedAction pinia.mjs:1399
    actionName pinia.mjs:932
    startComposerSession actions.js:517
    handleHttpAuthErrors sessionExpiryHandler.js:11
    startComposerSession actions.js:384
    wrappedAction pinia.mjs:1399
    actionName pinia.mjs:932

TODO

@st3iny st3iny self-assigned this May 6, 2025
@ChristophWurst
Copy link
Member

ChristophWurst commented May 6, 2025

Editor seems to work but there are some errors in the console to look at.

[Vue warn]: Error in render: "TypeError: can't access property "length", _vm.recipients is undefined"

found in

---> <RecipientInfo> at src/components/RecipientInfo.vue

Same on older commits:

19:56:04.428 TypeError: this.recipients is undefined
    handler RecipientInfo.vue:89
    VueJS 21
    As Lodash
    _update VueJS
    r NcModal-BS5vtogq.css:6
    VueJS 2
    mount NcModal-BS5vtogq.css:6
    $mount NcModal-BS5vtogq.css:6
    VueJS 5
    As Lodash
    _update VueJS
    r NcModal-BS5vtogq.css:6
    VueJS 2
    mount NcModal-BS5vtogq.css:6
    $mount NcModal-BS5vtogq.css:6
    VueJS 3
    As Lodash
    _update VueJS
    r NcModal-BS5vtogq.css:6
    VueJS 2
    mount NcModal-BS5vtogq.css:6
    $mount NcModal-BS5vtogq.css:6
    VueJS 3
    As Lodash
    _update VueJS
    r NcModal-BS5vtogq.css:6
    VueJS 2
    mount NcModal-BS5vtogq.css:6
    $mount NcModal-BS5vtogq.css:6
    VueJS 5
    As Lodash
    _update VueJS
    r NcModal-BS5vtogq.css:6
    VueJS 5
vue.runtime.esm.js:3953:16

@GretaD could you check this out?

@ChristophWurst
Copy link
Member

ChristophWurst commented Aug 4, 2025

is this obsolete?

@GretaD
Copy link
Contributor

GretaD commented Aug 7, 2025

is this obsolete?

i dont think so, we still need to upgrade to 45 eventually. The error, though, shouldnt be there anymore after rebase.

@st3iny st3iny force-pushed the fix/deps/update-ckeditor-installation-method branch from e7d2b7e to a3d4b89 Compare October 9, 2025 11:07
@st3iny st3iny marked this pull request as ready for review October 9, 2025 13:15
GretaD
GretaD approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played a bit around, and didnt find any issues

@ChristophWurst ChristophWurst mentioned this pull request Oct 9, 2025
Closed
1 task
@st3iny st3iny force-pushed the fix/deps/update-ckeditor-installation-method branch from 27d53bb to 819c221 Compare October 9, 2025 14:20
@st3iny st3iny enabled auto-merge October 9, 2025 14:22
@st3iny st3iny merged commit 79561d8 into main Oct 9, 2025
45 checks passed
@st3iny st3iny deleted the fix/deps/update-ckeditor-installation-method branch October 9, 2025 14:31
@GretaD GretaD mentioned this pull request Oct 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GretaD GretaD GretaD approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

Assignees

@st3iny st3iny

Labels

4. to release dependencies technical debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@st3iny @ChristophWurst @GretaD